hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3239) WebAppProxy does not support a final tracking url which has query fragments and params
Date Mon, 23 Feb 2015 18:29:16 GMT

    [ https://issues.apache.org/jira/browse/YARN-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333626#comment-14333626
] 

Jason Lowe commented on YARN-3239:
----------------------------------

the WebProxyServlet does support appending the client-provided path and query strings, as
I can verify it by simply curling a regular MapReduce app's proxy URL.  For example:

{noformat}
$ curl 'http://rmhost:8088/proxy/application_1424469840513_0001/foo/bar/boo?viewPath=a&other=b'
    
<html>
  <head>
    <title>
      Moved
    </title>
  </head>
  <body>
    <h1>
      Moved
    </h1>
    <div>
      Content has moved 
      <a href="http://jhshost:19888/jobhistory/job/job_1424469840513_0001/foo/bar/boo?viewPath=a&amp;other=b">here</a>
    </div>
  </body>
</html>
{noformat}

However it does not properly handle URI fragments supplied by either the app or the client,
and it doesn't honor query parameters set in the tracking URL by the app.

Thanks for the patch, Jian!  Patch looks good overall, and merging query strings between the
client and the app-specified URL seems reasonable.  However it doesn't look like we're honoring
any fragments provided by the client, and that would break clients for any app UIs that generate
fragment-containing links.

> WebAppProxy does not support a final tracking url which has query fragments and params

> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-3239
>                 URL: https://issues.apache.org/jira/browse/YARN-3239
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Jian He
>         Attachments: YARN-3239.1.patch
>
>
> Examples of failures:
> Expected: {{http://uihost:8080/#/main/views/TEZ/0.5.2.2.2.2.0-947/tez?viewPath=%2F%23%2Ftez-app%2Fapplication_1424384418229_0005}}
> Actual: {{http://uihost:8080}}
> Tried with a minor change to remove the "#". Saw a different issue:
> Expected: {{http://uihost:8080/views/TEZ/0.5.2.2.2.2.0-947/tez?viewPath=%2F%23%2Ftez-app%2Fapplication_1424388018547_0001}}
> Actual: {{http://uihost:8080/views/TEZ/0.5.2.2.2.2.0-947/tez/}}
> yarn application -status appId returns the expected value correctly. However, invoking
an http get on http://rm:8088/proxy/appId/ returns the wrong value. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message