hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuan Gong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3207) secondary filter matches entites which do not have the key being filtered for.
Date Wed, 18 Feb 2015 02:15:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325318#comment-14325318
] 

Xuan Gong commented on YARN-3207:
---------------------------------

+1 LGTM. Will commit.

> secondary filter matches entites which do not have the key being filtered for.
> ------------------------------------------------------------------------------
>
>                 Key: YARN-3207
>                 URL: https://issues.apache.org/jira/browse/YARN-3207
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>            Reporter: Prakash Ramachandran
>            Assignee: Zhijie Shen
>         Attachments: YARN-3207.1.patch
>
>
> in the leveldb implementation of the TimelineStore the secondary filter matches entities
where the key being searched for is not present.
> ex query from tez ui
> http://uvm:8188/ws/v1/timeline/TEZ_DAG_ID/?limit=1&secondaryFilter=foo:bar
> will match and return the entity even though there is no entity with otherinfo.foo defined.
> the issue seems to be in 
> {code:title=LeveldbTimelineStore:675}
> if (vs != null && !vs.contains(filter.getValue())) {
>   filterPassed = false;
>   break;
> }
> {code}
> this should be IMHO
> vs == null || !vs.contains(filter.getValue())



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message