[ https://issues.apache.org/jira/browse/YARN-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328669#comment-14328669
]
Devaraj K commented on YARN-3195:
---------------------------------
Thanks [~jagadesh.kiran] for your work, overall patch is ok except the below things to take
care.
1. These tests are failing due to the patch changes, can you have a look into these?
{code:xml}
org.apache.hadoop.yarn.client.cli.TestLogsCLI
org.apache.hadoop.yarn.client.cli.TestYarnCLI
{code}
2. We need to return the success exit code (i.e. 0) for help case since the help command execution
becomes success.
{code:xml}
+ if (args.length < 1 || args[0].equals("-help")) {
printHelpMessage(printOpts);
return -1;
}
{code}
BTW, can you also take care of formatting the newly added code and avoiding the new lines
addition when you create a patch.
> [YARN]Missing uniformity In Yarn Queue CLI command
> ---------------------------------------------------
>
> Key: YARN-3195
> URL: https://issues.apache.org/jira/browse/YARN-3195
> Project: Hadoop YARN
> Issue Type: Bug
> Components: client
> Affects Versions: 2.6.0
> Environment: SUSE Linux SP3
> Reporter: Jagadesh Kiran N
> Assignee: Jagadesh Kiran N
> Priority: Minor
> Fix For: 2.7.0
>
> Attachments: Helptobe removed in Queue.png, YARN-3195.patch
>
>
> Help is generic command should not be placed here because of this uniformity is missing
compared to other commands.Remove -help command inside ./yarn queue as uniformity with respect
to other commands
> {code}
> SO486LDPag65:/home/OpenSource/HA/install/hadoop/resourcemanager/bin # ./yarn queue -help
> 15/02/13 19:30:20 WARN util.NativeCodeLoader: Unable to load native-hadoop library for
your platform... using builtin-java classes where applicable
> usage: queue
> * -help Displays help for all commands.*
> -status <Queue Name> List queue information about given queue.
> SO486LDPag65:/home/OpenSource/HA/install/hadoop/resourcemanager/bin # ./yarn queue
> 15/02/13 19:33:14 WARN util.NativeCodeLoader: Unable to load native-hadoop library for
your platform... using builtin-java classes where applicable
> Invalid Command Usage :
> usage: queue
> * -help Displays help for all commands.*
> -status <Queue Name> List queue information about given queue.
> {code}
> * -help Displays help for all commands.*
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|