hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brahma Reddy Battula (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3192) Empty handler for exception: java.lang.InterruptedException #WebAppProxy.java and #/ResourceManager.java
Date Mon, 16 Feb 2015 12:36:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322711#comment-14322711
] 

Brahma Reddy Battula commented on YARN-3192:
--------------------------------------------

{quote}
 Signalling a clean shutdown is the desired action here, not exiting with a -1. Note also
our use of the sole exit mechanism we allow in the Hadoop codebase, via a call to ExitUtil.terminate(-1,
t);. That's new to branch-2+ as of this week; until then the code was "errant".

if you're going to touch join(), rather than have it throw, have it exit with a boolean to
indicate "managed shutdown vs interruption". It'll be ignored either way, but if it makes
you confident the code is better, then I wont say known.
{quote}

+1, for this approach..

> Empty handler for exception: java.lang.InterruptedException #WebAppProxy.java and #/ResourceManager.java
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3192
>                 URL: https://issues.apache.org/jira/browse/YARN-3192
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: YARN-3192.patch
>
>
> The InterruptedException is completely ignored. As a result, any events causing this
interrupt will be lost.
>  File: org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
> {code}
>    try {
>             event = eventQueue.take();
>           } catch (InterruptedException e) {
>             LOG.error("Returning, interrupted : " + e);
>             return; // TODO: Kill RM.
>           }
> {code}
> File: "org/apache/hadoop/yarn/server/webproxy/WebAppProxy.java"
> {code}
> public void join() {
>     if(proxyServer != null) {
>       try {
>         proxyServer.join();
>       } catch (InterruptedException e) {
>       }
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message