hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3182) Cleanup switch statement in ApplicationMasterLauncher#handle()
Date Fri, 13 Feb 2015 15:26:29 GMT

    [ https://issues.apache.org/jira/browse/YARN-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320296#comment-14320296
] 

Hudson commented on YARN-3182:
------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2054 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2054/])
YARN-3182. Cleanup switch statement in ApplicationMasterLauncher#handle(). Contributed by
Ray Chiang. (ozawa: rev 110cf6b9a3b64cc2159e708967b854f5a419d438)
* hadoop-yarn-project/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/amlauncher/ApplicationMasterLauncher.java


> Cleanup switch statement in ApplicationMasterLauncher#handle()
> --------------------------------------------------------------
>
>                 Key: YARN-3182
>                 URL: https://issues.apache.org/jira/browse/YARN-3182
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: YARN-3182.001.patch
>
>
> The last case in the switch statement relies on the break coming from the default case
instead of having it's own break.  It's a bit dangerous for any future code modifications
in this section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message