hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ray Chiang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3182) Cleanup switch statement in ApplicationMasterLauncher#handle()
Date Thu, 12 Feb 2015 06:47:14 GMT

    [ https://issues.apache.org/jira/browse/YARN-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317701#comment-14317701
] 

Ray Chiang commented on YARN-3182:
----------------------------------

RE: No new tests

Just a one-line functional equivalent fix.  Mainly a preventative code measure.  Found via
static code analysis.

> Cleanup switch statement in ApplicationMasterLauncher#handle()
> --------------------------------------------------------------
>
>                 Key: YARN-3182
>                 URL: https://issues.apache.org/jira/browse/YARN-3182
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>            Priority: Minor
>         Attachments: YARN-3182.001.patch
>
>
> The last case in the switch statement relies on the break coming from the default case
instead of having it's own break.  It's a bit dangerous for any future code modifications
in this section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message