hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3147) Clean up RM web proxy code
Date Thu, 12 Feb 2015 10:32:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317968#comment-14317968
] 

Steve Loughran commented on YARN-3147:
--------------------------------------

{{serviceStart()}} throws Exception, which gets caught and wrapped in the outer {{Service.start()}}
operation; this catch/wrap/rethrow is entirely needless. In fact, as it doesn't propagate
the nested exception's {{toString()}} value into the new string, actually makes things worse.

It's there because when I went through all those start() operations in YARN-117, I didn't
try to remove all such wrap operations; too much to change, makes the patch bigger and more
complex.

Now we're cleaning up one little module, we can cull it.

Now, if were to add more diagnostics, to the exception that would be different. At the very
least, though, it should go 
{{"Proxy Server Failed to login " + ie}}

> Clean up RM web proxy code 
> ---------------------------
>
>                 Key: YARN-3147
>                 URL: https://issues.apache.org/jira/browse/YARN-3147
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: webapp
>    Affects Versions: 2.6.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: YARN-3147-001.patch, YARN-3147-002.patch
>
>
> YARN-2084 covers fixing up the RM proxy & filter for REST support.
> Before doing that, prepare for it by cleaning up the codebase: factoring out the redirect
logic into a single method, some minor reformatting, move to SLF4J and Java7 code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message