hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3058) Fix error message of tokens' activation delay configuration
Date Wed, 04 Feb 2015 15:05:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305212#comment-14305212
] 

Hudson commented on YARN-3058:
------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #95 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/95/])
YARN-3058. Fix error message of tokens' activation delay configuration. Contributed by Yi
Liu. (ozawa: rev 26dee1486b70237a2a47f910472e9aa81ffad349)
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/NMTokenSecretManagerInRM.java
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/AMRMTokenSecretManager.java
* hadoop-yarn-project/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/RMContainerTokenSecretManager.java


> Fix error message of tokens' activation delay configuration
> -----------------------------------------------------------
>
>                 Key: YARN-3058
>                 URL: https://issues.apache.org/jira/browse/YARN-3058
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: YARN-3058.001.patch
>
>
> {code}
> this.rollingInterval = conf.getLong(
>          YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS,
>         YarnConfiguration.DEFAULT_RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS)
* 1000;
> ...
> this.activationDelay =
>         (long) (conf.getLong(YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS,
>             YarnConfiguration.DEFAULT_RM_NM_EXPIRY_INTERVAL_MS) * 1.5);
> ...
> if (rollingInterval <= activationDelay * 2) {
>       throw new IllegalArgumentException(
>           YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
>               + " should be more than 2 X "
>               + YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS);
>     }
> {code}
> The error msg should be 
> {code}
> YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
>               + " should be more than 3 X "
>               + YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS);
> {code}
> Also It's {{3 X}} instead of {{2 X}}, since it's multiplied by *1.5*.
> There are few other places having same issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message