hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3058) Fix error msg of tokens activation delay configuration
Date Wed, 04 Feb 2015 02:36:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304531#comment-14304531
] 

Tsuyoshi OZAWA commented on YARN-3058:
--------------------------------------

+1

> Fix error msg of tokens activation delay configuration
> ------------------------------------------------------
>
>                 Key: YARN-3058
>                 URL: https://issues.apache.org/jira/browse/YARN-3058
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>            Priority: Minor
>         Attachments: YARN-3058.001.patch
>
>
> {code}
> this.rollingInterval = conf.getLong(
>          YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS,
>         YarnConfiguration.DEFAULT_RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS)
* 1000;
> ...
> this.activationDelay =
>         (long) (conf.getLong(YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS,
>             YarnConfiguration.DEFAULT_RM_NM_EXPIRY_INTERVAL_MS) * 1.5);
> ...
> if (rollingInterval <= activationDelay * 2) {
>       throw new IllegalArgumentException(
>           YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
>               + " should be more than 2 X "
>               + YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS);
>     }
> {code}
> The error msg should be 
> {code}
> YarnConfiguration.RM_CONTAINER_TOKEN_MASTER_KEY_ROLLING_INTERVAL_SECS
>               + " should be more than 3 X "
>               + YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS);
> {code}
> Also It's {{3 X}} instead of {{2 X}}, since it's multiplied by *1.5*.
> There are few other places having same issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message