hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
Date Fri, 13 Feb 2015 13:56:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320096#comment-14320096
] 

Junping Du commented on YARN-2799:
----------------------------------

Patch looks good in overall. However, a comment for a trivial issue here:
In testAppLogDirCreation(), we create a new InlineDispatcher
{code}
    InlineDispatcher dispatcher = new InlineDispatcher();
{code}
but we doesn't stop it somewhere. Shall we add a stop() within the test?

> cleanup TestLogAggregationService based on the change in YARN-90
> ----------------------------------------------------------------
>
>                 Key: YARN-2799
>                 URL: https://issues.apache.org/jira/browse/YARN-2799
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: test
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: YARN-2799.000.patch, YARN-2799.001.patch
>
>
> cleanup TestLogAggregationService based on the change in YARN-90.
> The following code is added to setup in YARN-90, 
> {code}
>     dispatcher = createDispatcher();
>     appEventHandler = mock(EventHandler.class);
>     dispatcher.register(ApplicationEventType.class, appEventHandler);
> {code}
> In this case, we should remove all these code from each test function to avoid duplicate
code.
> Same for dispatcher.stop() which is in tearDown,
> we can remove dispatcher.stop() from from each test function also because it will always
be called from tearDown for each test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message