hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2694) Ensure only single node labels specified in resource request / host, and node label expression only specified when resourceName=ANY
Date Thu, 05 Feb 2015 21:10:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308002#comment-14308002
] 

Jian He commented on YARN-2694:
-------------------------------

few minor comments, looks good overall,

- check if empty too ?
{code}
    if (null == exp) {
      return;
    }
{code}
- remove the IOException from the method header
{code}
  private Map<NodeId, Set<String>> buildNodeLabelsMapFromStr(String args)
      throws IOException 
{code}
- exceed 80 column limit
{code}
private void verifyAddRequestFailed(AMRMClient<ContainerRequest> client, ContainerRequest
request) {
{code}
- Instead of throwing IOException, use precondition check too
{code}
if (labels.size() > 1) {
        String msg = String.format("%d labels specified on host=%s"
            + ", please note that we do not support specifying multiple"
            + " labels on a single host for now.", labels.size(),
            nodeId.getHost());
        LOG.error(msg);
        
{code}
- should the following check empty string too ?
{code}
 if (null == req.getNodeLabelExpression()
            && ResourceRequest.ANY.equals(req.getResourceName())) {
{code}
- maybe check “||” too ?
{code}
if (labelExp != null && labelExp.contains("&&")) {
{code}

> Ensure only single node labels specified in resource request / host, and node label expression
only specified when resourceName=ANY
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2694
>                 URL: https://issues.apache.org/jira/browse/YARN-2694
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2694-20141020-1.patch, YARN-2694-20141021-1.patch, YARN-2694-20141023-1.patch,
YARN-2694-20141023-2.patch, YARN-2694-20141101-1.patch, YARN-2694-20141101-2.patch, YARN-2694-20150121-1.patch,
YARN-2694-20150122-1.patch, YARN-2694-20150202-1.patch, YARN-2694-20150203-1.patch, YARN-2694-20150203-2.patch,
YARN-2694-20150204-1.patch
>
>
> Currently, node label expression supporting in capacity scheduler is partial completed.
Now node label expression specified in Resource Request will only respected when it specified
at ANY level. And a ResourceRequest/host with multiple node labels will make user limit, etc.
computation becomes more tricky.
> Now we need temporarily disable them, changes include,
> - AMRMClient
> - ApplicationMasterService
> - RMAdminCLI
> - CommonNodeLabelsManager



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message