hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1809) Synchronize RM and Generic History Service Web-UIs
Date Fri, 27 Feb 2015 22:02:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340894#comment-14340894

Zhijie Shen commented on YARN-1809:

Xuan, thanks for updating the patch. It looks good to me overall. Just some minor code improvement

1. In ApplicationHistoryClientService, make sure we don't change the implementation of getApp/AttemptContainer(s).

2. ApplicationHistoryManagerImpl doesn't need to be changed. It's already deprecated.

3. Why is the following code removed? It may result in page exception if the following checks
are not done.
95	    if (appReport == null) {		
96	      puts("Application not found: " + aid);		
97	      return;		
98	    }
93	    if (appAttemptReport == null) {		
94	      puts("Application Attempt not found: " + attemptid);		
95	      return;
88	    if (containerReport == null) {		
89	      puts("Container not found: " + containerid);		
90	      return;		
91	    }

3. In AppAttemptBlock.java, we need to the similar change that we did in AppBlock.java to
check the case that the tracking url  == N/A.

4. Since we excluded the change of scheduler webpage, isFairSchedulerPage is no longer necessary
in WebPageUtils.

AHS web services has been changed in this patch too. I did quick check, and it seemed to work
too. Please double check as well.

> Synchronize RM and Generic History Service Web-UIs
> --------------------------------------------------
>                 Key: YARN-1809
>                 URL: https://issues.apache.org/jira/browse/YARN-1809
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Zhijie Shen
>            Assignee: Xuan Gong
>         Attachments: YARN-1809.1.patch, YARN-1809.10.patch, YARN-1809.11.patch, YARN-1809.12.patch,
YARN-1809.13.patch, YARN-1809.14.patch, YARN-1809.2.patch, YARN-1809.3.patch, YARN-1809.4.patch,
YARN-1809.5.patch, YARN-1809.5.patch, YARN-1809.6.patch, YARN-1809.7.patch, YARN-1809.8.patch,
> After YARN-953, the web-UI of generic history service is provide more information than
that of RM, the details about app attempt and container. It's good to provide similar web-UIs,
but retrieve the data from separate source, i.e., RM cache and history store respectively.

This message was sent by Atlassian JIRA

View raw message