Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Wed, 28 Jan 2015 19:22:35 +0000 (UTC)
From: "Anubhav Dhoot (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12770269.1422336126000.196938.1422472955172@Atlassian.JIRA>
In-Reply-To: <JIRA.12770269.1422336126000@Atlassian.JIRA>
References: <JIRA.12770269.1422336126000@Atlassian.JIRA>
 <JIRA.12770269.1422336126374@arcas>
Subject: [jira] [Commented] (YARN-3101) FairScheduler#fitInMaxShare was
 added to validate reservations but it does not consider it
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295664#comment-14295664 ] 

Anubhav Dhoot commented on YARN-3101:
-------------------------------------

YARN-2811 added the following
{noformat}
private boolean fitInMaxShare(FSQueue queue) {
    if (Resources.fitsIn(queue.getResourceUsage(), queue.getMaxShare())) {
      return false;
    }
{noformat}

This should have been
{noformat}
if (!Resources.fitsIn(queue.getResourceUsage(), queue.getMaxShare()))
{noformat}

Because of this we would always reject reservations and hence the test was passing
Adding a new patch that shows this via a negative test case (reservation should not be dropped when not exceeding). This fails without the new fix.

> FairScheduler#fitInMaxShare was added to validate reservations but it does not consider it 
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-3101
>                 URL: https://issues.apache.org/jira/browse/YARN-3101
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-3101.001.patch, YARN-3101.002.patch
>
>
> YARN-2811 added fitInMaxShare to validate reservations on a queue, but did not count it during its calculations. It also had the condition reversed so the test was still passing because both cancelled each other. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)