Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0B4AE17471 for ; Tue, 27 Jan 2015 22:53:35 +0000 (UTC) Received: (qmail 62453 invoked by uid 500); 27 Jan 2015 22:53:35 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 62402 invoked by uid 500); 27 Jan 2015 22:53:35 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 62390 invoked by uid 99); 27 Jan 2015 22:53:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jan 2015 22:53:35 +0000 Date: Tue, 27 Jan 2015 22:53:35 +0000 (UTC) From: "Wangda Tan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3098) Create common QueueCapacities class in Capacity Scheduler to track capacities-by-labels of queues MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294354#comment-14294354 ] Wangda Tan commented on YARN-3098: ---------------------------------- [~sunilg], Thanks for review, For #1, I didn't do that because I think add a type as parameter is not clear enough, since they will be used very frequently, it's more important to me to keep interface clean and easy (than less duplications). Sounds reasonable? For #2, Sorry I'm not quite understand your point. Wangda > Create common QueueCapacities class in Capacity Scheduler to track capacities-by-labels of queues > ------------------------------------------------------------------------------------------------- > > Key: YARN-3098 > URL: https://issues.apache.org/jira/browse/YARN-3098 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacityscheduler > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: YARN-3098.1.patch, YARN-3098.2.patch, YARN-3098.3.patch, YARN-3098.4.patch > > > Similar to YARN-3092, after YARN-796, now queues (ParentQueue and LeafQueue) need to track capacities-label (e.g. absolute-capacity, maximum-capacity, absolute-capacity, absolute-maximum-capacity, etc.). It's better to have a class to encapsulate these capacities to make both better maintainability/readability and fine-grained locking. -- This message was sent by Atlassian JIRA (v6.3.4#6332)