Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 147D617600 for ; Tue, 27 Jan 2015 00:19:36 +0000 (UTC) Received: (qmail 58609 invoked by uid 500); 27 Jan 2015 00:19:36 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 58547 invoked by uid 500); 27 Jan 2015 00:19:36 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 58535 invoked by uid 99); 27 Jan 2015 00:19:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jan 2015 00:19:36 +0000 Date: Tue, 27 Jan 2015 00:19:36 +0000 (UTC) From: "Varun Saxena (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3075) NodeLabelsManager implementation to retrieve label to node mapping MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292697#comment-14292697 ] Varun Saxena commented on YARN-3075: ------------------------------------ [~leftnoteasy], bq. This seems not correct to me. n1 appears on p1 and p2, but label on host should not include label on nodes of the host. Now I can understand why 1) exists. I suggest to make this behavior consistent with getNodeLabels(), or at least we can make getNodeLabels() consistent with getLabelsToNodes. Thoughts? This is consistent with getNodeLabels(). I have included below piece of assertion in these test cases to check precisely whether getLabelsToNodes is consistent with getNodeLabels. {{transposeNodeToLabels}} transposes result from getNodeLabels() and matches it against getLabelsToNodes(). {code} assertLabelsToNodesEquals( labelsToNodes, transposeNodeToLabels(mgr.getNodeLabels())); {code} > NodeLabelsManager implementation to retrieve label to node mapping > ------------------------------------------------------------------ > > Key: YARN-3075 > URL: https://issues.apache.org/jira/browse/YARN-3075 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Affects Versions: 2.7.0 > Reporter: Varun Saxena > Assignee: Varun Saxena > Attachments: YARN-3075.001.patch, YARN-3075.002.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)