Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA1D01010B for ; Tue, 13 Jan 2015 13:21:33 +0000 (UTC) Received: (qmail 4395 invoked by uid 500); 13 Jan 2015 13:21:35 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 4351 invoked by uid 500); 13 Jan 2015 13:21:35 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 4337 invoked by uid 99); 13 Jan 2015 13:21:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2015 13:21:35 +0000 Date: Tue, 13 Jan 2015 13:21:35 +0000 (UTC) From: "Yi Liu (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3055) Fix allTokens issue in DelegationTokenRenewer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275172#comment-14275172 ] Yi Liu commented on YARN-3055: ------------------------------ Upload a new patch. > Fix allTokens issue in DelegationTokenRenewer > --------------------------------------------- > > Key: YARN-3055 > URL: https://issues.apache.org/jira/browse/YARN-3055 > Project: Hadoop YARN > Issue Type: Bug > Components: security > Reporter: Yi Liu > Assignee: Yi Liu > Attachments: YARN-3055.001.patch, YARN-3055.002.patch > > > In {{removeApplicationFromRenewal}}, when going to remove a token, and the token is shared by other jobs, we will not cancel the token. > Meanwhile, we should not cancel the _timerTask_, also we should not remove it from {{allTokens}}. Otherwise for the existing submitted applications which share this token will not get renew any more, and for new submitted applications which share this token, the token will be renew immediately. > For example, we have 3 applications: app1, app2, app3. And they share the token1. See following scenario: > *1).* app1 is submitted firstly, then app2, and then app3. In this case, there is only one token renewal timer for token1, and is scheduled when app1 is submitted > *2).* app1 is finished, then the renewal timer is cancelled. token1 will not be renewed any more, but app2 and app3 still use it, so there is problem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)