Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E17F410C7D for ; Mon, 26 Jan 2015 03:37:34 +0000 (UTC) Received: (qmail 70365 invoked by uid 500); 26 Jan 2015 03:37:35 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 70322 invoked by uid 500); 26 Jan 2015 03:37:35 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 70311 invoked by uid 99); 26 Jan 2015 03:37:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jan 2015 03:37:35 +0000 Date: Mon, 26 Jan 2015 03:37:35 +0000 (UTC) From: "Xuan Gong (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3024) LocalizerRunner should give DIE action when all resources are localized MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291427#comment-14291427 ] Xuan Gong commented on YARN-3024: --------------------------------- +1 LGTM. Will commit it > LocalizerRunner should give DIE action when all resources are localized > ----------------------------------------------------------------------- > > Key: YARN-3024 > URL: https://issues.apache.org/jira/browse/YARN-3024 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.6.0 > Reporter: Chengbing Liu > Assignee: Chengbing Liu > Attachments: YARN-3024.01.patch, YARN-3024.02.patch, YARN-3024.03.patch, YARN-3024.04.patch > > > We have observed that {{LocalizerRunner}} always gives a LIVE action at the end of localization process. > The problem is {{findNextResource()}} can return null even when {{pending}} was not empty prior to the call. This method removes localized resources from {{pending}}, therefore we should check the return value, and gives DIE action when it returns null. -- This message was sent by Atlassian JIRA (v6.3.4#6332)