Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 22 Jan 2015 03:25:34 +0000 (UTC)
From: "Xuan Gong (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12765959.1420788591000.142304.1421897134984@Atlassian.JIRA>
In-Reply-To: <JIRA.12765959.1420788591000@Atlassian.JIRA>
References: <JIRA.12765959.1420788591000@Atlassian.JIRA>
 <JIRA.12765959.1420788591845@arcas>
Subject: [jira] [Commented] (YARN-3024) LocalizerRunner should give DIE
 action when all resources are localized
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286898#comment-14286898 ] 

Xuan Gong commented on YARN-3024:
---------------------------------

[~chengbing.liu]
bq. Could you please review the changed logic described in my last comment?
The changed logic looks fine for me. Even if we submit multiple requests before the previous request is finished, those requests will be queued to process.

So, can we add the test cases to verify this changed behavior ? 

Others are looks good to me.


> LocalizerRunner should give DIE action when all resources are localized
> -----------------------------------------------------------------------
>
>                 Key: YARN-3024
>                 URL: https://issues.apache.org/jira/browse/YARN-3024
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.6.0
>            Reporter: Chengbing Liu
>            Assignee: Chengbing Liu
>         Attachments: YARN-3024.01.patch, YARN-3024.02.patch, YARN-3024.03.patch
>
>
> We have observed that {{LocalizerRunner}} always gives a LIVE action at the end of localization process.
> The problem is {{findNextResource()}} can return null even when {{pending}} was not empty prior to the call. This method removes localized resources from {{pending}}, therefore we should check the return value, and gives DIE action when it returns null.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)