hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3090) DeletionService can silently ignore deletion task failures
Date Tue, 27 Jan 2015 20:41:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294144#comment-14294144
] 

Jason Lowe commented on YARN-3090:
----------------------------------

It could be with some rework.  The hadoop-common class would either have to use its own logger
or be parameterized with the logger to use.  Since this is related to the DeletionService
arguably it should use that logger.

Don't know if we need to overthink this.  The derived class in question is just a few lines
of code, so not sure we need to put another class in hadoop-common for this one case.  If
we know there are many places it can/should be used then it's probably worth it, otherwise
I say we wait until we come up with another use case and commonize the code when it makes
sense (i.e.: the YAGNI principal).


> DeletionService can silently ignore deletion task failures
> ----------------------------------------------------------
>
>                 Key: YARN-3090
>                 URL: https://issues.apache.org/jira/browse/YARN-3090
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.1.1-beta
>            Reporter: Jason Lowe
>            Assignee: Varun Saxena
>
> If a non-I/O exception occurs while the DeletionService is executing a deletion task
then it will be silently ignored.  The exception bubbles up to the thread workers of the ScheduledThreadPoolExecutor
which simply attaches the throwable to the Future that was returned when the task was scheduled.
 However the thread pool is used as a fire-and-forget pool, so nothing ever looks at the Future
and therefore the exception is never logged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message