hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Payne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3089) LinuxContainerExecutor does not handle file arguments to deleteAsUser
Date Fri, 30 Jan 2015 14:03:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298637#comment-14298637
] 

Eric Payne commented on YARN-3089:
----------------------------------

Thank you, [~sunilg], for your review of this patch.

{quote}
{code}
int subDirEmptyStr = (subdir == NULL || subdir[0] == 0);
{code}
I think strlen(subdir) also has to be checked against 0, correct?
{quote}
The {{strlen}} function will do exactly the same thing that {{subdir[0] == 0}} does, which
is check that the first byte in the string is 0. In {{strlen}}, it takes the form of {{*s
== '\0'}}, but it amounts to the same thing. By checking for empty string as is done in the
existing patch, it avoids the overhead of another function call.

> LinuxContainerExecutor does not handle file arguments to deleteAsUser
> ---------------------------------------------------------------------
>
>                 Key: YARN-3089
>                 URL: https://issues.apache.org/jira/browse/YARN-3089
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Jason Lowe
>            Assignee: Eric Payne
>            Priority: Blocker
>         Attachments: YARN-3089.v1.txt
>
>
> YARN-2468 added the deletion of individual logs that are aggregated, but this fails to
delete log files when the LCE is being used.  The LCE native executable assumes the paths
being passed are paths and the delete fails.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message