hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Kanter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3079) Scheduler should also update maximumAllocation when updateNodeResource.
Date Wed, 28 Jan 2015 23:05:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296018#comment-14296018
] 

Robert Kanter commented on YARN-3079:
-------------------------------------

I think we should acquire {{maxAllocWriteLock}} on entering {{refreshMaximumAllocation()}}
and release it on exiting.  I could easily see someone in a future JIRA calling {{refreshMaximumAllocation()}}
without realizing that they need to acquire {{maxAllocWriteLock}} first.  {{maxAllocWriteLock}}
is reentrant, so there should be no harm is re-acquiring it.

+1 after that

> Scheduler should also update maximumAllocation when updateNodeResource.
> -----------------------------------------------------------------------
>
>                 Key: YARN-3079
>                 URL: https://issues.apache.org/jira/browse/YARN-3079
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-3079.000.patch, YARN-3079.001.patch, YARN-3079.002.patch, YARN-3079.003.patch
>
>
> Scheduler should also update maximumAllocation when updateNodeResource. Otherwise even
the node resource is changed by AdminService#updateNodeResource, maximumAllocation won't be
changed.
> Also RMNodeReconnectEvent called from ResourceTrackerService#registerNodeManager will
also trigger AbstractYarnScheduler#updateNodeResource being called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message