hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anubhav Dhoot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3079) Scheduler should also update maximumAllocation when updateNodeResource.
Date Tue, 27 Jan 2015 19:45:36 GMT

    [ https://issues.apache.org/jira/browse/YARN-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294060#comment-14294060
] 

Anubhav Dhoot commented on YARN-3079:
-------------------------------------

LGTM
Verified that the nodeUpdate is called from synchronized methods in both CapacityScheduler
and FairScheduler so removing and adding the node should not cause any NPE. The only impact
seems like we may miss the node in continuousScheduling when it gets removed, which should
be fine.
Added Tests look good 

> Scheduler should also update maximumAllocation when updateNodeResource.
> -----------------------------------------------------------------------
>
>                 Key: YARN-3079
>                 URL: https://issues.apache.org/jira/browse/YARN-3079
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-3079.000.patch, YARN-3079.001.patch, YARN-3079.002.patch, YARN-3079.003.patch
>
>
> Scheduler should also update maximumAllocation when updateNodeResource. Otherwise even
the node resource is changed by AdminService#updateNodeResource, maximumAllocation won't be
changed.
> Also RMNodeReconnectEvent called from ResourceTrackerService#registerNodeManager will
also trigger AbstractYarnScheduler#updateNodeResource being called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message