hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3075) NodeLabelsManager implementation to retrieve label to node mapping
Date Tue, 27 Jan 2015 09:39:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293256#comment-14293256
] 

Sunil G commented on YARN-3075:
-------------------------------

Hi [~varun_saxena]

{noformat}
 public Map<String, Set<NodeId>> getLabelsToNodes(Set<String> labels) {
{noformat}

It is always better to have 2 methods with different arguments. As you are trying to pass
null and achieving labels from labelCollections, and in normal case some other logic. IMHO
I feel that its more better are readable if you keep this separate.

> NodeLabelsManager implementation to retrieve label to node mapping
> ------------------------------------------------------------------
>
>                 Key: YARN-3075
>                 URL: https://issues.apache.org/jira/browse/YARN-3075
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.7.0
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-3075.001.patch, YARN-3075.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message