hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3075) NodeLabelsManager implementation to retrieve label to node mapping
Date Fri, 23 Jan 2015 10:33:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289062#comment-14289062

Varun Saxena commented on YARN-3075:

[~leftnoteasy], thanks for the review. Kindly find my replies below :

bq. 2) When op is on a node, as mentioned by Sunil, replace opertions not correct, it should
be remove and then add. 
That is what I am doing. Removing and add. [~sunilg] meant that we can refactor replaceNodeForLabels
and not reduplicate add already present in removeNodeFromLabels and addNodeForLabels function.
Did you mean something else ?

bq. 3.1 Two loop seems duplicated, you can set labels = labelCollections.entrySet when (labels
== null or empty).
That's a good suggestion. Will make the change

bq. 3.2 When labels == null or empty, it will returns nodes on all labels. You need add a
javadocs to brief this behavior and you need remove empty label from labelCollection like
what we did in getClusterNodeLabels. The "empty" label exists because we need track non-labeled
nodes in scheduler side but it shouldn't be seen by user.
Didn't know about that. Will remove the empty label.

> NodeLabelsManager implementation to retrieve label to node mapping
> ------------------------------------------------------------------
>                 Key: YARN-3075
>                 URL: https://issues.apache.org/jira/browse/YARN-3075
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.7.0
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-3075.001.patch

This message was sent by Atlassian JIRA

View raw message