hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3005) [JDK7] Use switch statement for String instead of if-else statement in RegistrySecurity.java
Date Sat, 10 Jan 2015 08:02:34 GMT

    [ https://issues.apache.org/jira/browse/YARN-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272400#comment-14272400
] 

Akira AJISAKA commented on YARN-3005:
-------------------------------------

Thanks for the patch [~sekikn]. Mostly looks good to me. Minor nit:
{code}
       throw new ServiceStateException(E_UNKNOWN_AUTHENTICATION_MECHANISM
-                                      + "\"" + auth + "\"");
+          + "\"" + auth + "\"");
{code}
Would you keep the original style?

> [JDK7] Use switch statement for String instead of if-else statement in RegistrySecurity.java
> --------------------------------------------------------------------------------------------
>
>                 Key: YARN-3005
>                 URL: https://issues.apache.org/jira/browse/YARN-3005
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Akira AJISAKA
>            Priority: Trivial
>              Labels: newbie
>         Attachments: YARN-3005.001.patch
>
>
> Since we have moved to JDK7, we can refactor the below if-else statement for String.
> {code}
>     // TODO JDK7 SWITCH
>     if (REGISTRY_CLIENT_AUTH_KERBEROS.equals(auth)) {
>       access = AccessPolicy.sasl;
>     } else if (REGISTRY_CLIENT_AUTH_DIGEST.equals(auth)) {
>       access = AccessPolicy.digest;
>     } else if (REGISTRY_CLIENT_AUTH_ANONYMOUS.equals(auth)) {
>       access = AccessPolicy.anon;
>     } else {
>       throw new ServiceStateException(E_UNKNOWN_AUTHENTICATION_MECHANISM
>                                       + "\"" + auth + "\"");
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message