hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2800) Remove MemoryNodeLabelsStore and add a way to enable/disable node labels feature
Date Fri, 23 Jan 2015 11:04:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289093#comment-14289093
] 

Tsuyoshi OZAWA commented on YARN-2800:
--------------------------------------

Thanks for your updating. I rechecked the code. RMNodeLabelsManager, FileSystemNodeLabelsStore,
RMAdminCLI can access to the variable nodeLabelsEnabled, but I agree with you that we don't
need to make nodeLabelsEnabled volatile since there are no problem in the code path.  

I'll update following comments to follow javadoc format. After that I'll commit it.

{code}
+  /*
+   * Following are options for node labels 
{code}

{code}
+  /*
+   * Error messages
+   */
{code}

> Remove MemoryNodeLabelsStore and add a way to enable/disable node labels feature
> --------------------------------------------------------------------------------
>
>                 Key: YARN-2800
>                 URL: https://issues.apache.org/jira/browse/YARN-2800
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2800-20141102-1.patch, YARN-2800-20141102-2.patch, YARN-2800-20141118-1.patch,
YARN-2800-20141118-2.patch, YARN-2800-20141119-1.patch, YARN-2800-20141203-1.patch, YARN-2800-20141205-1.patch,
YARN-2800-20141205-1.patch, YARN-2800-20150122-1.patch
>
>
> In the past, we have a MemoryNodeLabelStore, mostly for user to try this feature without
configuring where to store node labels on file system. It seems convenient for user to try
this, but actually it causes some bad use experience. User may add/remove labels, and edit
capacity-scheduler.xml. After RM restart, labels will gone, (we store it in mem). And RM cannot
get started if we have some queue uses labels, and the labels don't exist in cluster.
> As what we discussed, we should have an explicitly way to let user specify if he/she
wants this feature or not. If node label is disabled, any operations trying to modify/use
node labels will throw exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message