hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2800) Remove MemoryNodeLabelsStore and add a way to enable/disable node labels feature
Date Thu, 22 Jan 2015 09:42:36 GMT

    [ https://issues.apache.org/jira/browse/YARN-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287173#comment-14287173
] 

Tsuyoshi OZAWA commented on YARN-2800:
--------------------------------------

[~leftnoteasy], the patch looks good to me overall, but it is outdated. Could you rebase the
patch to include the changes against TestCapacitySchedulerNodeLabelUpdate?

Additionally, I think nodeLabelsEnabled should be defined as volatile variable since it's
accessed from multiple threads. Could you update it? 


> Remove MemoryNodeLabelsStore and add a way to enable/disable node labels feature
> --------------------------------------------------------------------------------
>
>                 Key: YARN-2800
>                 URL: https://issues.apache.org/jira/browse/YARN-2800
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2800-20141102-1.patch, YARN-2800-20141102-2.patch, YARN-2800-20141118-1.patch,
YARN-2800-20141118-2.patch, YARN-2800-20141119-1.patch, YARN-2800-20141203-1.patch, YARN-2800-20141205-1.patch,
YARN-2800-20141205-1.patch
>
>
> In the past, we have a MemoryNodeLabelStore, mostly for user to try this feature without
configuring where to store node labels on file system. It seems convenient for user to try
this, but actually it causes some bad use experience. User may add/remove labels, and edit
capacity-scheduler.xml. After RM restart, labels will gone, (we store it in mem). And RM cannot
get started if we have some queue uses labels, and the labels don't exist in cluster.
> As what we discussed, we should have an explicitly way to let user specify if he/she
wants this feature or not. If node label is disabled, any operations trying to modify/use
node labels will throw exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message