Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 10A4610205 for ; Wed, 31 Dec 2014 08:41:13 +0000 (UTC) Received: (qmail 29965 invoked by uid 500); 31 Dec 2014 08:41:13 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 29910 invoked by uid 500); 31 Dec 2014 08:41:13 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 29898 invoked by uid 99); 31 Dec 2014 08:41:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Dec 2014 08:41:13 +0000 Date: Wed, 31 Dec 2014 08:41:13 +0000 (UTC) From: "Rohith (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-3000) YARN_PID_DIR should be visible in yarn-env.sh MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262027#comment-14262027 ] Rohith commented on YARN-3000: ------------------------------ Kindly review attached patch > YARN_PID_DIR should be visible in yarn-env.sh > --------------------------------------------- > > Key: YARN-3000 > URL: https://issues.apache.org/jira/browse/YARN-3000 > Project: Hadoop YARN > Issue Type: Bug > Components: scripts > Affects Versions: 2.6.0 > Reporter: Jeff Zhang > Assignee: Rohith > Priority: Minor > Attachments: 0001-YARN-3000.patch > > > Currently I see YARN_PID_DIR only show in yarn-deamon.sh which is supposed not the place for user to set up enviroment variable. IMO, yarn-env.sh is the place for users to set up enviroment variable just like hadoop-env.sh, so it's better to put YARN_PID_DIR into yarn-env.sh. ( can put it into comment just like YARN_RESOURCEMANAGER_HEAPSIZE ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)