Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 06DC210C23 for ; Sat, 27 Dec 2014 11:31:16 +0000 (UTC) Received: (qmail 70283 invoked by uid 500); 27 Dec 2014 11:31:15 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 70248 invoked by uid 500); 27 Dec 2014 11:31:15 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 70231 invoked by uid 99); 27 Dec 2014 11:31:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Dec 2014 11:31:15 +0000 Date: Sat, 27 Dec 2014 11:31:15 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259348#comment-14259348 ] Hudson commented on YARN-2993: ------------------------------ FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #54 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/54/]) YARN-2993. Several fixes (missing acl check, error log msg ...) and some refinement in AdminService. (Contributed by Yi Liu) (junping_du: rev 40ee4bff65b2bfdabfd16ee7d9be3382a0476565) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java * hadoop-yarn-project/CHANGES.txt > Several fixes (missing acl check, error log msg ...) and some refinement in AdminService > ---------------------------------------------------------------------------------------- > > Key: YARN-2993 > URL: https://issues.apache.org/jira/browse/YARN-2993 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Reporter: Yi Liu > Assignee: Yi Liu > Attachments: YARN-2993.001.patch > > > This JIRA is to resolve following issues in {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}: > *1.* There is no ACLs check for {{refreshServiceAcls}} > *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can not refresh Admin ACLs."" instead of "... Can not refresh user-groups."" > *3.* some unnecessary header import. > *4.* {code} > if (!isRMActive()) { > RMAuditLogger.logFailure(user.getShortUserName(), argName, > adminAcl.toString(), "AdminService", > "ResourceManager is not active. Can not remove labels."); > throwStandbyException(); > } > {code} > is common in lots of methods, just the message is different, we should refine it into one common method. > *5.* {code} > LOG.info("Exception remove labels", ioe); > RMAuditLogger.logFailure(user.getShortUserName(), argName, > adminAcl.toString(), "AdminService", "Exception remove label"); > throw RPCUtil.getRemoteException(ioe); > {code} > is common in lots of methods, just the message is different, we should refine it into one common method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)