Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BC032CDDE for ; Thu, 25 Dec 2014 14:58:13 +0000 (UTC) Received: (qmail 62821 invoked by uid 500); 25 Dec 2014 14:58:13 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 62785 invoked by uid 500); 25 Dec 2014 14:58:13 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 62769 invoked by uid 99); 25 Dec 2014 14:58:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Dec 2014 14:58:13 +0000 Date: Thu, 25 Dec 2014 14:58:13 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2988) Graph#save() may leak file descriptors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258773#comment-14258773 ] Hudson commented on YARN-2988: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #53 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/53/]) YARN-2988. Graph#save() may leak file descriptors. (Ted Yu via ozawa) (ozawa: rev b256dd76006efbd4bcde3146a642fe0902d83dd2) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java > Graph#save() may leak file descriptors > -------------------------------------- > > Key: YARN-2988 > URL: https://issues.apache.org/jira/browse/YARN-2988 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Priority: Minor > Fix For: 2.7.0 > > Attachments: YARN-2988-001.patch, YARN-2988-002.patch > > > In hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java : > {code} > public void save(String filepath) throws IOException { > OutputStreamWriter fout = new OutputStreamWriter( > new FileOutputStream(filepath), Charset.forName("UTF-8")); > fout.write(generateGraphViz()); > fout.close(); > {code} > The close of fout should be enclosed in finally clause. -- This message was sent by Atlassian JIRA (v6.3.4#6332)