Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Fri, 12 Dec 2014 17:03:14 +0000 (UTC)
From: "Rohith (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12761216.1418349436000.11079.1418403794170@Atlassian.JIRA>
In-Reply-To: <JIRA.12761216.1418349436000@Atlassian.JIRA>
References: <JIRA.12761216.1418349436000@Atlassian.JIRA>
 <JIRA.12761216.1418349436368@arcas>
Subject: [jira] [Commented] (YARN-2952) Incorrect version check in
 RMStateStore
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244447#comment-14244447 ] 

Rohith commented on YARN-2952:
------------------------------

+1 for issue, always base major version is considered as 1. But in real use cases, base major version can be greater than 2 or 3 which installation itself will fail. 

> Incorrect version check in RMStateStore
> ---------------------------------------
>
>                 Key: YARN-2952
>                 URL: https://issues.apache.org/jira/browse/YARN-2952
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Rohith
>
> In RMStateStore#checkVersion:  if we modify  tCURRENT_VERSION_INFO to 2.0, it'll still store the version as 1.0 which is incorrect; The same thing might happen to NM store, timeline store.
> {code}
>     // if there is no version info, treat it as 1.0;
>     if (loadedVersion == null) {
>       loadedVersion = Version.newInstance(1, 0);
>     }
>     if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
>       LOG.info("Storing RM state version info " + getCurrentVersion());
>       storeVersion();
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)