Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1DFF910417 for ; Fri, 5 Dec 2014 17:49:13 +0000 (UTC) Received: (qmail 23901 invoked by uid 500); 5 Dec 2014 17:49:12 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 23861 invoked by uid 500); 5 Dec 2014 17:49:12 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 23848 invoked by uid 99); 5 Dec 2014 17:49:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2014 17:49:12 +0000 Date: Fri, 5 Dec 2014 17:49:12 +0000 (UTC) From: "Sunil G (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2925) Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235788#comment-14235788 ] Sunil G commented on YARN-2925: ------------------------------- HI [~wangda] Do you mean completely remove CS specific lock here, and protect only the data structures with lock from LeafQueue? > Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom > ----------------------------------------------------------------------------------------------------------------- > > Key: YARN-2925 > URL: https://issues.apache.org/jira/browse/YARN-2925 > Project: Hadoop YARN > Issue Type: Bug > Components: capacityscheduler > Reporter: Wangda Tan > Assignee: Wangda Tan > Priority: Critical > > Upon YARN-2644, FiCaScheduler will calculation up-to-date headroom before sending back Allocation response to AM. > Headroom calculation is happened in LeafQueue side, uses fields like used resource, etc. But it is not protected by any lock of LeafQueue, so it might be corrupted is someone else is editing it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)