Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC08A10D14 for ; Mon, 15 Dec 2014 18:40:17 +0000 (UTC) Received: (qmail 565 invoked by uid 500); 15 Dec 2014 18:40:17 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 518 invoked by uid 500); 15 Dec 2014 18:40:17 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 432 invoked by uid 99); 15 Dec 2014 18:40:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Dec 2014 18:40:17 +0000 Date: Mon, 15 Dec 2014 18:40:17 +0000 (UTC) From: "Karthik Kambatla (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-2914) Potential race condition in SharedCacheUploaderMetrics/CleanerMetrics/ClientSCMMetrics#getInstance() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Kambatla updated YARN-2914: ----------------------------------- Issue Type: Sub-task (was: Bug) Parent: YARN-1492 > Potential race condition in SharedCacheUploaderMetrics/CleanerMetrics/ClientSCMMetrics#getInstance() > ---------------------------------------------------------------------------------------------------- > > Key: YARN-2914 > URL: https://issues.apache.org/jira/browse/YARN-2914 > Project: Hadoop YARN > Issue Type: Sub-task > Affects Versions: 2.6.0 > Reporter: Ted Yu > Assignee: Varun Saxena > Priority: Minor > Fix For: 2.7.0 > > Attachments: YARN-2914.002.patch, YARN-2914.patch > > > {code} > public static ClientSCMMetrics getInstance() { > ClientSCMMetrics topMetrics = Singleton.INSTANCE.impl; > if (topMetrics == null) { > throw new IllegalStateException( > {code} > getInstance() doesn't hold lock on Singleton.this > This may result in IllegalStateException being thrown prematurely. > [~ctrezzo] reported that SharedCacheUploaderMetrics has also same kind of race condition. -- This message was sent by Atlassian JIRA (v6.3.4#6332)