[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238130#comment-14238130 ] 

Wangda Tan commented on YARN-2762:
----------------------------------

[~rohithsharma],
Thanks for update,
Last two minor comments:
- Rename {{NO_LABEL}} to {{NO_LABEL_ERR_MSG}}.
- Make {{"No node-to-labels mappings are specified"}} to a final field as well, like {{NO_MAPPING_ERR_MSG}}.

Wangda

> RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-2762
>                 URL: https://issues.apache.org/jira/browse/YARN-2762
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Rohith
>            Assignee: Rohith
>            Priority: Minor
>         Attachments: YARN-2762.1.patch, YARN-2762.2.patch, YARN-2762.2.patch, YARN-2762.3.patch, YARN-2762.4.patch, YARN-2762.5.patch, YARN-2762.patch
>
>
> All NodeLabel args validation's are done at server side. The same can be done at RMAdminCLI so that unnecessary RPC calls can be avoided.
> And for the input such as "x,y,,z,", no need to add empty string instead can be skipped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)