hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3000) YARN_PID_DIR should be visible in yarn-env.sh
Date Wed, 31 Dec 2014 09:22:14 GMT

    [ https://issues.apache.org/jira/browse/YARN-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262048#comment-14262048
] 

Hadoop QA commented on YARN-3000:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12689660/0001-YARN-3000.patch
  against trunk revision e7257ac.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6225//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6225//console

This message is automatically generated.

> YARN_PID_DIR should be visible in yarn-env.sh
> ---------------------------------------------
>
>                 Key: YARN-3000
>                 URL: https://issues.apache.org/jira/browse/YARN-3000
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.6.0
>            Reporter: Jeff Zhang
>            Assignee: Rohith
>            Priority: Minor
>         Attachments: 0001-YARN-3000.patch
>
>
> Currently I see YARN_PID_DIR only show in yarn-deamon.sh which is supposed not the place
for user to set up enviroment variable. IMO, yarn-env.sh is the place for users to set up
enviroment variable just like hadoop-env.sh, so it's better to put YARN_PID_DIR into yarn-env.sh.
( can put it into comment just like YARN_RESOURCEMANAGER_HEAPSIZE )



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message