hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2993) Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
Date Sat, 27 Dec 2014 15:29:14 GMT

    [ https://issues.apache.org/jira/browse/YARN-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259386#comment-14259386
] 

Hudson commented on YARN-2993:
------------------------------

SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2005 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2005/])
YARN-2993. Several fixes (missing acl check, error log msg ...) and some refinement in AdminService.
(Contributed by Yi Liu) (junping_du: rev 40ee4bff65b2bfdabfd16ee7d9be3382a0476565)
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/AdminService.java
* hadoop-yarn-project/CHANGES.txt


> Several fixes (missing acl check, error log msg ...) and some refinement in AdminService
> ----------------------------------------------------------------------------------------
>
>                 Key: YARN-2993
>                 URL: https://issues.apache.org/jira/browse/YARN-2993
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: YARN-2993.001.patch
>
>
> This JIRA is to resolve following issues in {{org.apache.hadoop.yarn.server.resourcemanager.AdminService}}:
> *1.* There is no ACLs check for {{refreshServiceAcls}}
> *2.* log message in {{refreshAdminAcls}} is incorrect, it should be "... Can not refresh
Admin ACLs."" instead of "... Can not refresh user-groups.""
> *3.* some unnecessary header import.
> *4.* {code}
> if (!isRMActive()) {
>   RMAuditLogger.logFailure(user.getShortUserName(), argName,
>       adminAcl.toString(), "AdminService",
>       "ResourceManager is not active. Can not remove labels.");
>   throwStandbyException();
> }
> {code}
> is common in lots of methods, just the message is different, we should refine it into
one common method.
> *5.* {code}
> LOG.info("Exception remove labels", ioe);
> RMAuditLogger.logFailure(user.getShortUserName(), argName,
>     adminAcl.toString(), "AdminService", "Exception remove label");
> throw RPCUtil.getRemoteException(ioe);
> {code}
> is common in lots of methods, just the message is different, we should refine it into
one common method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message