hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (YARN-2988) Graph#save() may leak resource
Date Tue, 23 Dec 2014 20:33:13 GMT
Ted Yu created YARN-2988:
----------------------------

             Summary: Graph#save() may leak resource
                 Key: YARN-2988
                 URL: https://issues.apache.org/jira/browse/YARN-2988
             Project: Hadoop YARN
          Issue Type: Bug
            Reporter: Ted Yu
            Assignee: Ted Yu
            Priority: Minor


In hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java
:
{code}
  public void save(String filepath) throws IOException {
    OutputStreamWriter fout = new OutputStreamWriter(
        new FileOutputStream(filepath), Charset.forName("UTF-8"));
    fout.write(generateGraphViz());
    fout.close();
{code}
The close of fout should be enclosed in finally clause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message