hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2988) Graph#save() may leak file descriptors
Date Thu, 25 Dec 2014 11:42:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258734#comment-14258734
] 

Hudson commented on YARN-2988:
------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #52 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/52/])
YARN-2988. Graph#save() may leak file descriptors. (Ted Yu via ozawa) (ozawa: rev b256dd76006efbd4bcde3146a642fe0902d83dd2)
* hadoop-yarn-project/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java


> Graph#save() may leak file descriptors
> --------------------------------------
>
>                 Key: YARN-2988
>                 URL: https://issues.apache.org/jira/browse/YARN-2988
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: YARN-2988-001.patch, YARN-2988-002.patch
>
>
> In hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java
:
> {code}
>   public void save(String filepath) throws IOException {
>     OutputStreamWriter fout = new OutputStreamWriter(
>         new FileOutputStream(filepath), Charset.forName("UTF-8"));
>     fout.write(generateGraphViz());
>     fout.close();
> {code}
> The close of fout should be enclosed in finally clause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message