hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2975) FSLeafQueue app lists are accessed without required locks
Date Thu, 18 Dec 2014 22:52:14 GMT

    [ https://issues.apache.org/jira/browse/YARN-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252467#comment-14252467
] 

Karthik Kambatla commented on YARN-2975:
----------------------------------------

I understand the concern. Pre-YARN-2910, we were in the exact same place and haven't seen
any issues in practice. Let me take a look again and see if we can do what you are suggesting
- do all of removeApp while holding the writeLock. Initially, I had a single method, but had
to split based on prior accesses. 





> FSLeafQueue app lists are accessed without required locks
> ---------------------------------------------------------
>
>                 Key: YARN-2975
>                 URL: https://issues.apache.org/jira/browse/YARN-2975
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Blocker
>         Attachments: yarn-2975-1.patch
>
>
> YARN-2910 adds explicit locked access to runnable and non-runnable apps in FSLeafQueue.
As FSLeafQueue has getters for these, they can be accessed without locks in other places.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message