hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2975) FSLeafQueue app lists are accessed without required locks
Date Thu, 18 Dec 2014 20:38:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252205#comment-14252205
] 

Karthik Kambatla commented on YARN-2975:
----------------------------------------

[~adhoot] - I see your point about consistency. If the app was not runnable at the time of
check but becomes runnable by the time we remove it, we can miss untracking it. May be, we
should clean up how we store runnability of an app in FSAppAttempt, and add transitions like
rest of RM code to handle addition, move, removal of the apps. The scope might be too big
to do in this JIRA. Okay with doing it in a follow-up? 

By the way, thanks a bunch for taking the time to review. 

> FSLeafQueue app lists are accessed without required locks
> ---------------------------------------------------------
>
>                 Key: YARN-2975
>                 URL: https://issues.apache.org/jira/browse/YARN-2975
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Blocker
>         Attachments: yarn-2975-1.patch
>
>
> YARN-2910 adds explicit locked access to runnable and non-runnable apps in FSLeafQueue.
As FSLeafQueue has getters for these, they can be accessed without locks in other places.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message