hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
Date Sat, 20 Dec 2014 11:42:15 GMT

    [ https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254663#comment-14254663
] 

Hudson commented on YARN-2952:
------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #47 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/47/])
YARN-2952. Fixed incorrect version check in StateStore. Contributed by Rohith Sharmaks (jianhe:
rev 808cba3821d5bc4267f69d14220757f01cd55715)
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/LeveldbTimelineStore.java
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
* hadoop-yarn-project/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java


> Incorrect version check in RMStateStore
> ---------------------------------------
>
>                 Key: YARN-2952
>                 URL: https://issues.apache.org/jira/browse/YARN-2952
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Rohith
>             Fix For: 2.7.0
>
>         Attachments: 0001-YARN-2952.patch
>
>
> In RMStateStore#checkVersion:  if we modify  tCURRENT_VERSION_INFO to 2.0, it'll still
store the version as 1.0 which is incorrect; The same thing might happen to NM store, timeline
store.
> {code}
>     // if there is no version info, treat it as 1.0;
>     if (loadedVersion == null) {
>       loadedVersion = Version.newInstance(1, 0);
>     }
>     if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
>       LOG.info("Storing RM state version info " + getCurrentVersion());
>       storeVersion();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message