hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2938) Fix new findbugs warnings in hadoop-yarn-resourcemanager and hadoop-yarn-applicationhistoryservice
Date Fri, 12 Dec 2014 07:52:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243834#comment-14243834
] 

Varun Saxena commented on YARN-2938:
------------------------------------

Next findbugs issue is that of *BX_UNBOXING_IMMEDIATELY_REBOXED* in {{org.apache.hadoop.yarn.server.timeline.MemoryTimelineStore}}
This issue can be fixed if I change {{currentTimestamp}} to Long in statement {{long currentTimestamp
= System.currentTimeMillis();}}
But as it is a rank 18 findbugs issue, didnt bother changing it. If you want, can fix it.
{code}
  public void put(TimelineDomain domain) throws IOException {
    TimelineDomain domainToReplace =
        domainsById.get(domain.getId());
    long currentTimestamp = System.currentTimeMillis();
    TimelineDomain domainToStore = createTimelineDomain(
        domain.getId(), domain.getDescription(), domain.getOwner(),
        domain.getReaders(), domain.getWriters(),
        (domainToReplace == null ?
            currentTimestamp : domainToReplace.getCreatedTime()),
        currentTimestamp);
   ...
  }
{code}

> Fix new findbugs warnings in hadoop-yarn-resourcemanager and hadoop-yarn-applicationhistoryservice
> --------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2938
>                 URL: https://issues.apache.org/jira/browse/YARN-2938
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>             Fix For: 2.7.0
>
>         Attachments: YARN-2938.001.patch, YARN-2938.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message