hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2925) Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom
Date Mon, 08 Dec 2014 19:51:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238365#comment-14238365
] 

Wangda Tan commented on YARN-2925:
----------------------------------

[~cwelch],
Thanks for your comments, your suggestion makes sense to me, I will:
- Drop the existing QueueResourceInfo implementation, and will do refactoring in future patch
- Add a fine grain lock only for headroom computing to resolve both consistent and stale issue,
will include user consumed resource and used resource. I suggest to use read/write to achieve
better performance. 

Any thoughts? Will work on a patch later.

Thanks,

> Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp
to calculate Headroom
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2925
>                 URL: https://issues.apache.org/jira/browse/YARN-2925
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Critical
>         Attachments: YARN-2925.1.patch
>
>
> Upon YARN-2644, FiCaScheduler will calculation up-to-date headroom before sending back
Allocation response to AM.
> Headroom calculation is happened in LeafQueue side, uses fields like used resource, etc.
But it is not protected by any lock of LeafQueue, so it might be corrupted is someone else
is editing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message