hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2922) Concurrent Modification Exception in LeafQueue when collecting applications
Date Wed, 10 Dec 2014 01:57:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240508#comment-14240508
] 

Akira AJISAKA commented on YARN-2922:
-------------------------------------

Thanks for creating the patch, [~rohithsharma].
{code}
@@ -1887,7 +1887,7 @@ public Resource getTotalResourcePending() {
   }
 
   @Override
-  public void collectSchedulerApplications(
+  public synchronized void collectSchedulerApplications(
{code}
I'm thinking we don't need the synchronization in collectSchedulerApplications, and it's better
to use read-write lock for performance. You can use the latest patch in YARN-2910 as reference.


> Concurrent Modification Exception in LeafQueue when collecting applications
> ---------------------------------------------------------------------------
>
>                 Key: YARN-2922
>                 URL: https://issues.apache.org/jira/browse/YARN-2922
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager, scheduler
>    Affects Versions: 2.5.1
>            Reporter: Jason Tufo
>            Assignee: Rohith
>         Attachments: 0001-YARN-2922.patch
>
>
> java.util.ConcurrentModificationException
>                 at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1115)
>                 at java.util.TreeMap$KeyIterator.next(TreeMap.java:1169)
>                 at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue.collectSchedulerApplications(LeafQueue.java:1618)
>                 at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.getAppsInQueue(CapacityScheduler.java:1119)
>                 at org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.getQueueInfo(ClientRMService.java:798)
>                 at org.apache.hadoop.yarn.api.impl.pb.service.ApplicationClientProtocolPBServiceImpl.getQueueInfo(ApplicationClientProtocolPBServiceImpl.java:234)
>                 at org.apache.hadoop.yarn.proto.ApplicationClientProtocol$ApplicationClientProtocolService$2.callBlockingMethod(ApplicationClientProtocol.java:333)
>                 at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:585)
>                 at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:928)
>                 at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2013)
>                 at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2009)
>                 at java.security.AccessController.doPrivileged(Native Method)
>                 at javax.security.auth.Subject.doAs(Subject.java:415)
>                 at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1614)
>                 at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2007)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message