hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2914) Potential race condition in SharedCacheUploaderMetrics/CleanerMetrics/ClientSCMMetrics#getInstance()
Date Thu, 04 Dec 2014 23:06:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234765#comment-14234765
] 

Tsuyoshi OZAWA commented on YARN-2914:
--------------------------------------

LGTM(non-binding).

> Potential race condition in SharedCacheUploaderMetrics/CleanerMetrics/ClientSCMMetrics#getInstance()
> ----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2914
>                 URL: https://issues.apache.org/jira/browse/YARN-2914
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Ted Yu
>            Assignee: Varun Saxena
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: YARN-2914.002.patch, YARN-2914.patch
>
>
> {code}
>   public static ClientSCMMetrics getInstance() {
>     ClientSCMMetrics topMetrics = Singleton.INSTANCE.impl;
>     if (topMetrics == null) {
>       throw new IllegalStateException(
> {code}
> getInstance() doesn't hold lock on Singleton.this
> This may result in IllegalStateException being thrown prematurely.
> [~ctrezzo] reported that SharedCacheUploaderMetrics has also same kind of race condition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message