[ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236654#comment-14236654
]
Hadoop QA commented on YARN-2762:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12685522/YARN-2762.5.patch
against trunk revision e227fb8.
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified
test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of
javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version
2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number
of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client:
org.apache.hadoop.yarn.client.TestResourceTrackerOnHA
org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6020//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6020//console
This message is automatically generated.
> RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM
> --------------------------------------------------------------------------------------
>
> Key: YARN-2762
> URL: https://issues.apache.org/jira/browse/YARN-2762
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Rohith
> Assignee: Rohith
> Priority: Minor
> Attachments: YARN-2762.1.patch, YARN-2762.2.patch, YARN-2762.2.patch, YARN-2762.3.patch,
YARN-2762.4.patch, YARN-2762.5.patch, YARN-2762.patch
>
>
> All NodeLabel args validation's are done at server side. The same can be done at RMAdminCLI
so that unnecessary RPC calls can be avoided.
> And for the input such as "x,y,,z,", no need to add empty string instead can be skipped.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|