hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM
Date Fri, 05 Dec 2014 18:02:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235807#comment-14235807
] 

Sunil G commented on YARN-2762:
-------------------------------

HI [~rohithsharma]

Good catch. I have some minor nits.
1. 
{code}
if (labels.size() == 0) 
{code}
Better we can use labels.isEmpty()

2. I feel other exception message also can be made similar to NO_LABEL if no issues.

3. Could tests be updated to verify exceptions which are raised on empty cluster node-labels?

> RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-2762
>                 URL: https://issues.apache.org/jira/browse/YARN-2762
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Rohith
>            Assignee: Rohith
>            Priority: Minor
>         Attachments: YARN-2762.1.patch, YARN-2762.2.patch, YARN-2762.2.patch, YARN-2762.3.patch,
YARN-2762.4.patch, YARN-2762.patch
>
>
> All NodeLabel args validation's are done at server side. The same can be done at RMAdminCLI
so that unnecessary RPC calls can be avoided.
> And for the input such as "x,y,,z,", no need to add empty string instead can be skipped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message