hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2762) RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM
Date Thu, 04 Dec 2014 19:13:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234499#comment-14234499
] 

Wangda Tan commented on YARN-2762:
----------------------------------

[~rohithsharma],
I thought you uploaded a wrong patch :)

bq. Do you mean validation check for variable map i.e Map<NodeId, Set<String>>
map = new HashMap<NodeId, Set<String>>(); 
Yes 

bq. should be done not only for map.isEmpty but also for map values i.e set individually?
If so, what if input string is host1:port,, host2:port,x?
host1:port host2,x has another meaning, which means user wants to remove all labels in host1.

Thanks,

> RMAdminCLI node-labels-related args should be trimmed and checked before sending to RM
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-2762
>                 URL: https://issues.apache.org/jira/browse/YARN-2762
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Rohith
>            Assignee: Rohith
>            Priority: Minor
>         Attachments: YARN-2762.1.patch, YARN-2762.2.patch, YARN-2762.2.patch, YARN-2762.patch
>
>
> All NodeLabel args validation's are done at server side. The same can be done at RMAdminCLI
so that unnecessary RPC calls can be avoided.
> And for the input such as "x,y,,z,", no need to add empty string instead can be skipped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message