hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlo Curino (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2664) Improve RM webapp to expose info about reservations.
Date Wed, 03 Dec 2014 23:17:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233658#comment-14233658

Carlo Curino commented on YARN-2664:

[~mazzu], the patch looks good, I will give you a bunch of code-level comments to polish it
a little further:

 # in YarnWebParams.java: can we name those parameter (JSON_USER, JSON_RES_NAME, JSON_FROM,
JSON_TO) something more descriptive? Like PLAN_*? 
 # is graph.js your code? If so format it a little more if you can (there are some very long
lines). Also no need for declaring this is related to YARN-2664 in the header.
 # in DataPage.createJSON. Shall we make also a null check for getAllReservations() ? or are
we sure it is never null?
 # in NavBlock would be good to add the "Planner" link only if reservation are enabled (look
in YarnConfiguration for the switch).
I am now try to set this up in a small cluster, and see how it looks/functions. 

> Improve RM webapp to expose info about reservations.
> ----------------------------------------------------
>                 Key: YARN-2664
>                 URL: https://issues.apache.org/jira/browse/YARN-2664
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Carlo Curino
>            Assignee: Matteo Mazzucchelli
>         Attachments: PlannerPage_screenshot.pdf, YARN-2664.1.patch, YARN-2664.2.patch,
YARN-2664.3.patch, YARN-2664.4.patch, YARN-2664.5.patch, YARN-2664.6.patch, YARN-2664.patch,
> YARN-1051 provides a new functionality in the RM to ask for reservation on resources.
Exposing this through the webapp GUI is important.

This message was sent by Atlassian JIRA

View raw message