Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7DF84109BD for ; Tue, 18 Nov 2014 21:21:34 +0000 (UTC) Received: (qmail 96989 invoked by uid 500); 18 Nov 2014 21:21:34 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 96944 invoked by uid 500); 18 Nov 2014 21:21:34 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 96932 invoked by uid 99); 18 Nov 2014 21:21:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Nov 2014 21:21:34 +0000 Date: Tue, 18 Nov 2014 21:21:34 +0000 (UTC) From: "Karthik Kambatla (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-2865) Application recovery continuously fails with "Application with id already present. Cannot duplicate" MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216806#comment-14216806 ] Karthik Kambatla commented on YARN-2865: ---------------------------------------- Patch looks mostly good. Minor comments - we should reduce the visibility of the class and its methods to package-private, mark it @Private @Unstable, and add comments that this class is expected to be used only by RMContext and ResourceManager. I just want to guard against new code using this instead of RMContext; we might want this to be accessible in the future, but we should probably keep the changes small in this JIRA. > Application recovery continuously fails with "Application with id already present. Cannot duplicate" > ---------------------------------------------------------------------------------------------------- > > Key: YARN-2865 > URL: https://issues.apache.org/jira/browse/YARN-2865 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Reporter: Rohith > Assignee: Rohith > Priority: Critical > Attachments: YARN-2865.patch, YARN-2865.patch > > > YARN-2588 handles exception thrown while transitioningToActive and reset activeServices. But it misses out clearing RMcontext apps/nodes details and ClusterMetrics and QueueMetrics. This causes application recovery to fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)